Revert PR 1270: Direct access to current TCB inside stack macros#1272
Revert PR 1270: Direct access to current TCB inside stack macros#1272kar-rahul-aws merged 1 commit intoFreeRTOS:mainfrom
Conversation
FreeRTOS#1270)" This reverts commit 4162ca4.
|
There was a problem hiding this comment.
@aggarg Thank you for the changes, can you please fix the link-verifier CI check failure? I think it might be a transient error that might be fixed if restarted as they are all too-many-requests errors.
…#1273) * Cortex R4 demo: replace setup script with linked resources * Cortex R4 demo: remove Eclipse user settings
|
@aggarg As the issue #1270，the taskCHECK_FOR_STACK_OVERFLOW macro is invoked within the vTaskSwitchContext function, which itself may be called by the swi (software interrupt) handler. The call graph is as follows: Line 5254 in fed39c5 Is the proper functioning of the aforementioned code dependent on |
portSET_INTERRUPT_MASK_FROM_ISR/portCLEAR_INTERRUPT_MASK_FROM_ISR are only needed for nested interrupt. The context switch interrupt runs at the lowest priority and therefore, it should not be a problem. |
4 participants
Description
This reverts PR 1270. As concluded in the discussion here, if
portSET_INTERRUPT_MASKandportCLEAR_INTERRUPT_MASKare implemented correctly to support recursive calls, this change is not needed.Test Steps
NA.
Checklist:
Related Issue
NA.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.